Feat (INVT-CPC 885 ) : Ability to get product by id and details page #541

Abdur-Siddiqui · 2023-10-11T04:51:02Z

JIRA: link to jira ticket
https://champlainsaintlambert.atlassian.net/browse/CPC-885

Context:

I added a new feature called get product by product ID, inside the inventory
I created a new page called product details which displays the details of a product

Changes

Created a new folder called Product Details and finished front end
Implemented the back-end for get product details
My changes affect products

Before and After UI (Required for UI-impacting PRs)

Before

After

When you press the back products button it brings you back to inventory products page

…front-end

… details

…s and the inventory id also, and theres a back button that goes to products

Matthewtan9 · 2023-10-11T04:59:04Z

api-gateway/src/main/resources/static/scripts/app.js

-    , 'visits', 'vetList','vetForm','vetDetails', 'visitList', 'billForm', 'billUpdateForm', 'loginForm', 'rolesDetails', 'signupForm',
-    'billDetails', 'billsByOwnerId', 'billHistory','billsByVetId','inventoryList', 'inventoryForm', 'productForm','inventoryProductList', 'inventoryUpdateForm', 'productUpdateForm'
-    , 'verification' , 'adminPanel','resetPwdForm','forgotPwdForm','petTypeList']);
+    , 'visits', 'vetList','vetForm','vetDetails', 'visitList', 'billForm', 'billUpdateForm', 'loginForm', 'rolesDetails', 'signupForm', 'productDetailsInfo',


Why do you think it was necessary to add "productDetailsInfo" in the app.js?

If i didn't add the product detail info, in the app.js, then my page would never render when called.

That's very smart thank you for your input Mr Siddiqui.

DiSavio

I approve of the code everything looks good. Look at my comments that I left about the big-warning on the edit button because I coded that part and wanted to know your thought process on changing it. Other then that great work Abdur keep it up, brother.

DiSavio · 2023-10-11T04:59:36Z

api-gateway/src/main/resources/static/scripts/app.js

-    , 'visits', 'vetList','vetForm','vetDetails', 'visitList', 'billForm', 'billUpdateForm', 'loginForm', 'rolesDetails', 'signupForm',
-    'billDetails', 'billsByOwnerId', 'billHistory','billsByVetId','inventoryList', 'inventoryForm', 'productForm','inventoryProductList', 'inventoryUpdateForm', 'productUpdateForm'
-    , 'verification' , 'adminPanel','resetPwdForm','forgotPwdForm','petTypeList']);
+    , 'visits', 'vetList','vetForm','vetDetails', 'visitList', 'billForm', 'billUpdateForm', 'loginForm', 'rolesDetails', 'signupForm', 'productDetailsInfo',


Glad that you found out, that the order matters when setting the module on the app.js when it comes to loading new files.

Thanks, took me a while to figure it out but after doing some debugging found my issue.

DiSavio · 2023-10-11T05:01:23Z

...rc/main/resources/static/scripts/inventory-product-list/inventory-product-list.template.html

        <td><a ui-sref="updateProductInventory({inventoryId: $ctrl.inventoryProductList[0].inventoryId, productId: product.productId})">
-            <button class="add-bundle-button btn btn-success">Edit</button>
+            <button class="add-bundle-button btn btn-warning">Edit</button>


Can you elaborate on why you changed the btn-success to the btn-warning?

My pleasure, so I changed the color from btn -success to btn - warning, because green means success and you haven't changed or modified any value yet, thats why i changed the btn color to yellow to show that you need to test the functionality of the button.

I see thank you for informing me. It does make sense now because it will also match better with the inventory since the other update button in the inventories has it on "Warning" as well now that I look at it.

github-actions · 2023-10-11T05:06:23Z

Qodana for JVM

341 new problems were found

Inspection name	Severity	Problems
`Redundant character escape`	🔶 Warning	85
`Unused import`	🔶 Warning	82
`Dangling Javadoc comment`	🔶 Warning	14
`Invalid YAML configuration`	🔶 Warning	11
`Integer multiplication or shift implicitly cast to 'long'`	🔶 Warning	9
`Default annotation parameter value`	🔶 Warning	5
`Lombok annotations`	🔶 Warning	5
`Optional.get() is called without isPresent() check`	🔶 Warning	5
`AutoCloseable used without 'try'-with-resources`	🔶 Warning	4
`Deprecated API usage`	🔶 Warning	4
`Field can be local`	🔶 Warning	4
`Link specified as plain text`	🔶 Warning	4
`@NotNull/@Nullable problems`	🔶 Warning	4
`Redundant local variable`	🔶 Warning	4
`Unused assignment`	🔶 Warning	4
`Possibly blocking call in non-blocking context`	🔶 Warning	3
`Nullability and data flow problems`	🔶 Warning	3
`Spring Data repository method parameters errors`	🔶 Warning	3
`'Optional' used as field or parameter type`	🔶 Warning	2
`Unused publisher`	🔶 Warning	2
`Redundant type cast`	🔶 Warning	2
`Call to 'printStackTrace()'`	🔶 Warning	2
`Field may be 'final'`	🔶 Warning	1
`Lombok @Getter may be used`	🔶 Warning	1
`Mismatch in @PathVariable declarations and usages`	🔶 Warning	1
`Redundant 'close()'`	🔶 Warning	1
`Begin or end anchor in unexpected position`	🔶 Warning	1
`'size() == 0' can be replaced with 'isEmpty()'`	🔶 Warning	1
`Unnecessary call to 'toString()'`	🔶 Warning	1
`Commented out code`	◽️ Notice	37
`Non recommended 'field' injections`	◽️ Notice	18
`Duplicated code fragment`	◽️ Notice	14
`Constant values`	◽️ Notice	1
`Mismatch in @PathVariable declarations and usages`	◽️ Notice	1
`Throw statement in Reactive operator`	◽️ Notice	1
`Regular expression can be simplified`	◽️ Notice	1

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Or via our issue tracker: https://jb.gg/qodana-issue
Or share your feedback: https://jb.gg/qodana-discussions

Abdur-Siddiqui added 13 commits October 11, 2023 00:05

created a new folder called product-details and started implementing …

16d94b6

…front-end

when user clicks on get product details it brings them to a page with…

7a06e46

… details

Made changed to the form

9f3e363

styled the product details form

5c6e2b2

the details page shows information about product

c98528a

the form is fully functional it gets the product by id and its detial…

f34cae9

…s and the inventory id also, and theres a back button that goes to products

Fixed styling for product details, added a product card

a3c02a1

started implementing test classes

010c891

fixed merge conflcits and form works

074d552

integrtaion test

1bf8a53

finsihed controller integration test started unit test

8a19798

al inventory service tests are completed

eddbc83

finished get product by inventory and prouduct id test in api gateway

05a9fde

Matthewtan9 reviewed Oct 11, 2023

View reviewed changes

DiSavio approved these changes Oct 11, 2023

View reviewed changes

Matthewtan9 approved these changes Oct 11, 2023

View reviewed changes

Abdur-Siddiqui merged commit ebda4d2 into main Oct 11, 2023
3 checks passed

Abdur-Siddiqui deleted the feat/INVT-CPC-885_Ability_To_Get_Product_By_Id_And_Details_Page branch October 11, 2023 05:10

Abdur-Siddiqui restored the feat/INVT-CPC-885_Ability_To_Get_Product_By_Id_And_Details_Page branch October 17, 2023 02:13

Abdur-Siddiqui deleted the feat/INVT-CPC-885_Ability_To_Get_Product_By_Id_And_Details_Page branch October 17, 2023 02:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat (INVT-CPC 885 ) : Ability to get product by id and details page #541

Feat (INVT-CPC 885 ) : Ability to get product by id and details page #541

Abdur-Siddiqui commented Oct 11, 2023

Matthewtan9 Oct 11, 2023

Abdur-Siddiqui Oct 11, 2023

Matthewtan9 Oct 11, 2023

DiSavio left a comment

DiSavio Oct 11, 2023

Abdur-Siddiqui Oct 11, 2023

DiSavio Oct 11, 2023 •

edited

Loading

Abdur-Siddiqui Oct 11, 2023

DiSavio Oct 11, 2023

github-actions bot commented Oct 11, 2023

Feat (INVT-CPC 885 ) : Ability to get product by id and details page #541

Feat (INVT-CPC 885 ) : Ability to get product by id and details page #541

Conversation

Abdur-Siddiqui commented Oct 11, 2023

Context:

Changes

Before and After UI (Required for UI-impacting PRs)

Matthewtan9 Oct 11, 2023

Choose a reason for hiding this comment

Abdur-Siddiqui Oct 11, 2023

Choose a reason for hiding this comment

Matthewtan9 Oct 11, 2023

Choose a reason for hiding this comment

DiSavio left a comment

Choose a reason for hiding this comment

DiSavio Oct 11, 2023

Choose a reason for hiding this comment

Abdur-Siddiqui Oct 11, 2023

Choose a reason for hiding this comment

DiSavio Oct 11, 2023 • edited Loading

Choose a reason for hiding this comment

Abdur-Siddiqui Oct 11, 2023

Choose a reason for hiding this comment

DiSavio Oct 11, 2023

Choose a reason for hiding this comment

github-actions bot commented Oct 11, 2023

Qodana for JVM

DiSavio Oct 11, 2023 •

edited

Loading